RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v5]

Alan Bateman alanb at openjdk.java.net
Tue Apr 12 07:30:39 UTC 2022


On Tue, 12 Apr 2022 07:10:54 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/zip/ZipFile.java line 347:
>> 
>>> 345:      *
>>> 346:      * @implNote This implementation returns an instance of
>>> 347:      * {@link java.util.zip.InflaterInputStream}.
>> 
>> What is the reasoning for this note, do we really want it in the API docs?
>
> Hello Alan, this change was done by Volker for the point that I raised in the comment here https://github.com/openjdk/jdk/pull/7986#issuecomment-1081319691

> Hello Alan, this change was done by Volker for the point that I raised in the comment here [#7986 (comment)](https://github.com/openjdk/jdk/pull/7986#issuecomment-1081319691)

I think it creates the temptation to cast the returned input stream to InflaterInputStream, it might be better to leave it out.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7986


More information about the core-libs-dev mailing list