RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v6]
zimmermann6
duke at openjdk.java.net
Tue Apr 12 09:01:41 UTC 2022
On Tue, 8 Feb 2022 22:11:34 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020 [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about multi-line (block) comments. Nothing in the code proper has changed, except for the addition of redundant but clarifying parentheses in some expressions.
>>
>>
>> Greetings
>> Raffaello
>
> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Adapted hashes in ElementStructureTest.java
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Merge branch 'master' into JDK-4511638
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Enhanced intervals in MathUtils.
> Updated references to Schubfach v4.
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Merge branch 'master' into JDK-4511638
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Slight adjustments to Javadoc as suggested in the JDK-8202555 (CSR) comments.
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Adjusted hashes in test/langtools/tools/javac/sym/ElementStructureTest.java
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Merge branch 'master' into JDK-4511638
> - 4511638: Double.toString(double) sometimes produces incorrect results
> - 4511638: Double.toString(double) sometimes produces incorrect results
>
> Refactored test classes to better match OpenJDK conventions.
> Added tests recommended by Guy Steele and Paul Zimmermann.
> - Changed MAX_CHARS to static
> - ... and 2 more: https://git.openjdk.java.net/jdk/compare/92f4f40d...c29dff76
for the record, I post here the review we did with Jean-Michel Muller of the Schubfach algorithm in last October
[review.pdf](https://github.com/openjdk/jdk/files/8471359/review.pdf)
-------------
PR: https://git.openjdk.java.net/jdk/pull/3402
More information about the core-libs-dev
mailing list