RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]

Roger Riggs rriggs at openjdk.java.net
Tue Apr 19 14:38:37 UTC 2022


On Mon, 7 Mar 2022 18:47:17 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
>> 
>>> 687:      */
>>> 688:     @Override
>>> 689:     public boolean isIsoBased() {
>> 
>> Is this meant to be 'default'?  The CSR indicated adding default methods.
>
> The `default` method has been added to `java.time.chrono.Chronology` interface. This is its overridden method implemented in `IsoChronology` concrete class.

To make navigation easier, change the @code references to be @links and include the IsoField name.

I don't think the @implspec is needed, its redundant with @return.

Apply similar changes to the other ISO chronologies javadoc.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7683


More information about the core-libs-dev mailing list