RFR: 8285366: Fix typos in serviceability
Kevin Walls
kevinw at openjdk.java.net
Thu Apr 21 16:21:26 UTC 2022
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> I ran `codespell` on modules owned by the serviceability team (`java.instrument java.management.rmi java.management jdk.attach jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi jdk.jdwp.agent jdk.jstatd jdk.management.agent jdk.management`), and accepted those changes where it indeed discovered real typos.
>
>
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
>
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.
All looks good to me, just the invokable which you might want to leave as is, unless there are other strong feelings. 8-)
src/jdk.jdwp.agent/share/native/libjdwp/invoker.h line 38:
> 36: jboolean pending; /* Is an invoke requested? */
> 37: jboolean started; /* Is an invoke happening? */
> 38: jboolean available; /* Is the thread in an invocable state? */
invocable could perhaps stay as invokable ?
Elsewhere we have a filename com/sun/tools/jdi/InvokableTypeImpl.java which we clearly don't want to change, and I see Internet dictionary evidence of invokable being acceptable.
-------------
Marked as reviewed by kevinw (Committer).
PR: https://git.openjdk.java.net/jdk/pull/8334
More information about the core-libs-dev
mailing list