RFR: 8284992: Fix misleading Vector API doc for LSHR operator [v4]
Jie Fu
jiefu at openjdk.java.net
Fri Apr 29 06:35:44 UTC 2022
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by `LSHR` will be different from that of `>>>`.
> For more details, please see https://github.com/openjdk/jdk/pull/8276#issue-1206391831 .
>
> After the patch, the doc for `LSHR` is
>
> Produce zero-extended right shift of a by (n&(ESIZE*8-1)) bits. Integral only.
>
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Address CSR review comments
- Merge branch 'master' into JDK-8284992
- Address review comments
- Merge branch 'master' into JDK-8284992
- Merge branch 'master' into JDK-8284992
- Address review comments
- Merge branch 'master' into JDK-8284992
- 8284992: Fix misleading Vector API doc for LSHR operator
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8291/files
- new: https://git.openjdk.java.net/jdk/pull/8291/files/7e82e721..0161571b
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8291&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8291&range=02-03
Stats: 6657 lines in 233 files changed: 5591 ins; 490 del; 576 mod
Patch: https://git.openjdk.java.net/jdk/pull/8291.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8291/head:pull/8291
PR: https://git.openjdk.java.net/jdk/pull/8291
More information about the core-libs-dev
mailing list