RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v4]
Stuart Marks
smarks at openjdk.org
Mon Aug 1 23:37:14 UTC 2022
On Fri, 6 May 2022 22:05:35 GMT, liach <duke at openjdk.org> wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare values by identity. Updated API documentation of these two methods ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object))) to mention such behavior.
>
> liach has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Move tests
> - Merge branch 'master' into fix/identityhashmap-default
> - Fix assertions
> - Revamp test and changes. Let ci run the tests
> - Fix indent
> - 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V)
No action needed from you at this time. This is mostly waiting for me to get some time to focus on this. Thanks for your patience.
-------------
PR: https://git.openjdk.org/jdk/pull/8259
More information about the core-libs-dev
mailing list