RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs [v3]

Peter Levart plevart at openjdk.org
Wed Aug 3 22:17:45 UTC 2022


On Fri, 29 Jul 2022 09:38:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Peter Levart has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Nits from review comments
>
> test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java line 34:
> 
>> 32: 
>> 33: /*
>> 34:  * @test id=with_G1GC
> 
> The test identifiers can be just "G1", "Parallel", "Serial", etc.

I found a test where those identifiers were used, but now I see other tests where shorter id(s) are used and they are in majority. Adjusted accordingly in next commit.

> test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java line 72:
> 
>> 70:     /**
>> 71:      * Test methods execute in same VM and are ordered by name.
>> 72:      * We test effectiveness 1st which is sensitive to previous allocations when ZGC is used.
> 
> Comment mentions ZGC?

Yes, only with ZGC I found it is necessary to respect this order of testing otherwise the test might fail.

-------------

PR: https://git.openjdk.org/jdk/pull/9684


More information about the core-libs-dev mailing list