RFR: 8291924: jpackage: l10n for Windows context menu label

Alexey Semenyuk asemenyuk at openjdk.org
Thu Aug 4 20:34:16 UTC 2022


On Thu, 4 Aug 2022 18:10:18 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> This change adds `ContextMenuCommandLabel` l10n property for file association context menu label. It is a follow-up to [this PR comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
> 
> Note, non-EN l10n values were filled using auto-translator and may need to be corrected.
> 
> To check the contents of the label, registry query is added to `PackageTest::addHelloAppFileAssociationsVerifier`.
> 
> Testing:
> 
>  - [x] ran `FileAssociationsTest` with `install` enabled

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java line 359:

> 357:     }
> 358: 
> 359:     public static String queryRegistryValue(String keyPath, String valueName) {

It should be sufficient to make it package private, not public.

-------------

PR: https://git.openjdk.org/jdk/pull/9753


More information about the core-libs-dev mailing list