RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

Jaikiran Pai jpai at openjdk.org
Fri Aug 5 07:58:48 UTC 2022


On Thu, 4 Aug 2022 06:25:27 GMT, ScientificWare <duke at openjdk.org> wrote:

>> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>>  - Remove unused imports.
>>    
>>    Some imports are no more used.
>>    
>>    - java.io.FileNotFoundException;
>>    - java.io.BufferedInputStream;
>>    - java.io.OutputStream;
>>    - java.util.BitSet;
>>    - java.util.StringTokenizer;
>>    - java.util.Properties;
>>    - java.util.zip.DeflaterOutputStream;
>>    - java.util.zip.Deflater;
>>    - java.net.URL;
>
> Just waiting to be reviewed.

Hello @scientificware, what you propose here, I think looks fine. Additionally can you also update the copyright years on this file from `Copyright (c) 1998, 2020,` to `Copyright (c) 1998, 2022,`?

I see that the changed file resides at `make/jdk/src/classes/build/tools/dtdbuilder/DTDBuilder.java` and I think this needs to be reviewed by the build team. @magicus, is it OK if I re-add the `build` label for this PR?

-------------

PR: https://git.openjdk.org/jdk/pull/9360


More information about the core-libs-dev mailing list