RFR: 8291924: jpackage: l10n for Windows context menu label [v2]

Naoto Sato naoto at openjdk.org
Fri Aug 5 17:14:08 UTC 2022


On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>> This change adds `ContextMenuCommandLabel` l10n property for file association context menu label. It is a follow-up to [this PR comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>> 
>> Note, non-EN l10n values were filled using auto-translator and may need to be corrected.
>> 
>> To check the contents of the label, registry query is added to `PackageTest::addHelloAppFileAssociationsVerifier`.
>> 
>> Testing:
>> 
>>  - [x] ran `FileAssociationsTest` with `install` enabled
>
> Alex Kasko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reg method access, drop l10n entries, label check enhancement

Looks good for the translation file change.

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9753


More information about the core-libs-dev mailing list