RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Aug 8 08:50:07 UTC 2022
On Fri, 5 Aug 2022 09:55:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder
>> - Remove unused imports.
>>
>> Some imports are no more used.
>>
>> - java.io.FileNotFoundException;
>> - java.io.BufferedInputStream;
>> - java.io.OutputStream;
>> - java.util.BitSet;
>> - java.util.StringTokenizer;
>> - java.util.Properties;
>> - java.util.zip.DeflaterOutputStream;
>> - java.util.zip.Deflater;
>> - java.net.URL;
>
> You are right, the copyright year on the file is fine - I was looking at an older version of this file.
@jaikiran The build tools are not really part of the build system as such. I used to push for a solution to move them to their corresponding modules, but this met with resistance and did not really go anywhere.
In general, though, the build tools needs to be reviewed by the group "owning" them. In some cases, the change affects how the build tool interacts with the rest of the build system. If that is the case, the build label is relevant.
Unfortunately, the Skara label rules are a bit too coarse to capture this reality.
-------------
PR: https://git.openjdk.org/jdk/pull/9360
More information about the core-libs-dev
mailing list