RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false" [v2]

[Leonid Mesnik]

On Tue, 9 Aug 2022 02:35:14 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The test should use the same locales in all processes, the default language should work fine.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix

> I tried a few locales and could not reproduce the problem, I was expecting some kind of mismatch would trigger it, but not sure what to set and where to cause this...

It is needed to verify that the locale in java has been changed and that not G1 is used. The G1 'S0' is 0.00 which is zero for all locales and test passe because of your issue. I used additional logs to check that locale was actually updated.


Also, it is needed to see language with "," as a decimal delimiter.


> 
> Something else I noticed while looking, however: I looked at JstatGCUtilParser.java / verify(String... valueArray) I see it checks values are of the right type: but after almost all checks, it does a "break", so stops iterating values. Only percentage checks permit checking to continue. 8-) There are three "break" statements in verify(String... valueArray) which should be "continue". We can handle that in a separate issue.

Thank you! that explains a lot! I've updated the fix.

-------------

PR: https://git.openjdk.org/jdk/pull/9798