RFR: 8291978: jpackage: allow to override primary l10n files on Windows [v3]

Alex Kasko akasko at openjdk.org
Wed Aug 10 13:12:57 UTC 2022


> This change is a follow-up to [this comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
> 
> Override implementation is based on [this comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14510886&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14510886).
> 
> As suggested in [this comment](https://github.com/openjdk/jdk/pull/9753#pullrequestreview-1062560789) only English translation is provided for new `resource.wxl-file` label.
> 
> `getTempdirectory` utility was moved from `BasicTest` to `WindowsHelper` to be able to provide `--temp` and inspect the contents of `config` dir in verifier. It is not clear if `WindowsHelper` is an appropriate place for this utility (`BasicTest` is not Windows-specific), I've assumed that `--temp` flag itself is only used on Windows.
> 
> Testing:
> 
>  - [x] enhanced `WinL10nTest` adding checks for `-loc` arguments to `light.exe` and additional `@Parameter` run that overrides one of the primary `.wxl` files
>  - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode

Alex Kasko has updated the pull request incrementally with one additional commit since the last revision:

  fixes for bundling with different cultures

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9780/files
  - new: https://git.openjdk.org/jdk/pull/9780/files/097ae46e..a6e6ee1c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9780&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9780&range=01-02

  Stats: 52 lines in 7 files changed: 33 ins; 3 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/9780.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9780/head:pull/9780

PR: https://git.openjdk.org/jdk/pull/9780


More information about the core-libs-dev mailing list