Integrated: 8291978: jpackage: allow to override primary l10n files on Windows

Alex Kasko akasko at openjdk.org
Wed Aug 10 20:38:08 UTC 2022


On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> This change is a follow-up to [this comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
> 
> Override implementation is based on [this comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14510886&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14510886).
> 
> As suggested in [this comment](https://github.com/openjdk/jdk/pull/9753#pullrequestreview-1062560789) only English translation is provided for new `resource.wxl-file` label.
> 
> `getTempdirectory` utility was moved from `BasicTest` to `WindowsHelper` to be able to provide `--temp` and inspect the contents of `config` dir in verifier. It is not clear if `WindowsHelper` is an appropriate place for this utility (`BasicTest` is not Windows-specific), I've assumed that `--temp` flag itself is only used on Windows.
> 
> Testing:
> 
>  - [x] enhanced `WinL10nTest` adding checks for `-loc` arguments to `light.exe` and additional `@Parameter` run that overrides one of the primary `.wxl` files
>  - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode

This pull request has now been integrated.

Changeset: 543163a0
Author:    Alex Kasko <akasko at openjdk.org>
Committer: Alexey Semenyuk <asemenyuk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/543163a03b5f1af7a7e7af317a26eb8c5aa81c38
Stats:     152 lines in 11 files changed: 99 ins; 16 del; 37 mod

8291978: jpackage: allow to override primary l10n files on Windows

Reviewed-by: asemenyuk, almatvee, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/9780


More information about the core-libs-dev mailing list