RFR: 8289049: x86_32 build fails with GCC 11 due to newString646_US warning [v2]

Aleksey Shipilev shade at openjdk.org
Mon Aug 15 11:56:14 UTC 2022


On Mon, 1 Aug 2022 14:50:48 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See bug report for reproducer and error message. The warning looks quite superficial, and I initially suspected that it complains about `int len = (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the similar code in `newStringCp1252`  apparently does not produce the warning: https://github.com/openjdk/jdk/blob/f5d1b5bda27c798347ae278cbf69725ed4be895c/src/java.base/share/native/libjava/jni_util.c#L533-L566
>> 
>> I propose we chalk it up to false/odd compiler warning and sync up unproblematic `newStringCp1252` and `newString646_US` implementation to dodge it.
>> 
>> Additional testing:
>>  - [x] Linux x86_32 build with GCC 11
>>  - [x]  Linux x86_32 `tier1` test with GCC 9
>>  - [x]  Linux x86_64 `tier1` test with GCC 9
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Init buf in newStringCp1252

Any thoughts?

-------------

PR: https://git.openjdk.org/jdk/pull/9702


More information about the core-libs-dev mailing list