RFR: 8292051: jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java failed "AssertionError: Expected terminated values: [666] but got: []" [v2]

Peter Levart plevart at openjdk.org
Tue Aug 16 12:41:26 UTC 2022


On Tue, 16 Aug 2022 11:12:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Change the test to use a custom scheduler so there is better control on when the carrier threads terminates. Also convert test to TestNG so that all test cases can be run in the context of a virtual thread.
>
> Alan Bateman has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove unnecesary check
>  - Merge ffc681f3cccfdf473d4cc037e5f3e50f8172eec3 from plevart

This looks good.

-------------

Marked as reviewed by plevart (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9819


More information about the core-libs-dev mailing list