RFR: JDK-8289106: Add model of class file versions to core reflection [v6]
Roger Riggs
rriggs at openjdk.org
Tue Aug 16 14:51:30 UTC 2022
On Wed, 10 Aug 2022 01:54:56 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> JDK-8289106: Add model of class file versions to core reflection
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
>
> - Implement code review feedback.
> - Update ClassFileVersionTest.java.
> - Merge branch 'master' into JDK-8289106
> - Appease jcheck.
> - Finish more precise versioned location support; udpate tests.
> - Partial implementation of version-depdendent locations() with tests.
> - Merge branch 'master' into JDK-8289106
> - Merge branch 'master' into JDK-8289106
> - Add method to map from major class file version.
> - Merge branch 'master' into JDK-8289106
> - ... and 8 more: https://git.openjdk.org/jdk/compare/b9293502...2e6dfc8e
Looks good.
src/java.base/share/classes/java/lang/reflect/ClassFileFormatVersion.java line 259:
> 257: RELEASE_20(64);
> 258:
> 259: private int major;
Could be final?
-------------
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9299
More information about the core-libs-dev
mailing list