Integrated: 8289049: x86_32 build fails with GCC 11 due to newString646_US warning
Aleksey Shipilev
shade at openjdk.org
Wed Aug 17 12:54:47 UTC 2022
On Mon, 1 Aug 2022 11:46:52 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> See bug report for reproducer and error message. The warning looks quite superficial, and I initially suspected that it complains about `int len = (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the similar code in `newStringCp1252` apparently does not produce the warning: https://github.com/openjdk/jdk/blob/f5d1b5bda27c798347ae278cbf69725ed4be895c/src/java.base/share/native/libjava/jni_util.c#L533-L566
>
> I propose we chalk it up to false/odd compiler warning and sync up unproblematic `newStringCp1252` and `newString646_US` implementation to dodge it.
>
> Additional testing:
> - [x] Linux x86_32 build with GCC 11
> - [x] Linux x86_32 `tier1` test with GCC 9
> - [x] Linux x86_64 `tier1` test with GCC 9
This pull request has now been integrated.
Changeset: 0c67fba1
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/0c67fba11f444cc3739f66c8a2d57564b5dcca72
Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
8289049: x86_32 build fails with GCC 11 due to newString646_US warning
Reviewed-by: alanb, stuefe
-------------
PR: https://git.openjdk.org/jdk/pull/9702
More information about the core-libs-dev
mailing list