Integrated: 8292352: 32-bit Windows build failures after JDK-8290059

Aleksey Shipilev shade at openjdk.org
Wed Aug 17 13:27:35 UTC 2022


On Mon, 15 Aug 2022 11:16:06 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> The affected file was added by [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059), and the code that fails the compilation is under `#ifdef _WIN32`, and it only (?) gets compiled for tests. Looks like we really need the "WINAPI" macro in the definition, so that we match the stdcall. See the example declaration in the [docs](https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/ms686736(v=vs.85)).
> 
> Attn @JornVernee.
> 
> Additional testing:
>  - [x] Windows x86_32 builds, `java/foreign` tests now pass
>  - [x] Windows x86_64 builds, `java/foreign` tests still pass

This pull request has now been integrated.

Changeset: e81210f5
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e81210f5fe03ea3dc9c9fb0dba2be79e1dcc03bc
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8292352: 32-bit Windows build failures after JDK-8290059

Reviewed-by: stuefe

-------------

PR: https://git.openjdk.org/jdk/pull/9875


More information about the core-libs-dev mailing list