RFR: JDK-8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]" [v2]

Joe Darcy darcy at openjdk.org
Wed Aug 17 23:11:24 UTC 2022


On Wed, 17 Aug 2022 22:53:55 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> Its a shame. Code changes look good. I recommend adding an internal comment within the top of the class declaration indicating why anon inner classes are used, esp. since this there is more action at a distance than the usual case where lambdas are used too early in the JDK initialization process.

Agree that adding an explanatory comment is a good practice; I thought the same myself shortly after creating the PR :-)

-------------

PR: https://git.openjdk.org/jdk/pull/9911


More information about the core-libs-dev mailing list