RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

Aleksey Shipilev shade at openjdk.org
Fri Aug 19 13:03:47 UTC 2022


On Thu, 11 Aug 2022 20:09:06 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> Split the java/util/stream/SpinedBufferTest.java test into two parts:
> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases
> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases
> 
> I couldn't figure out a way to set a larger timeout value for the entirety
> of java/util/stream/SpinedBufferTest.java and I saw that other folks solved
> this problem with testng tests by splitting the test into more parts.
> 
> This fix is being tested in my jdk-20+10 stress testing run.

Looks like `sizes` initialization now gets duplicated too. I think you can do a super-class with these utility methods, the extend the subclasses with actual tests off it.

I agree with @PaulSandoz that we better split it by type. It would also give us meaningful test names, not just `SpinedBufferTest1`. Also, even more parallelism/timeout room :)

test/jdk/java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest1.java line 29:

> 27: 
> 28: import java.util.*;
> 29: //import java.util.function.DoubleConsumer;

These commented out imports should go away.

-------------

Changes requested by shade (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9845


More information about the core-libs-dev mailing list