RFR: 8291118: [vectorapi] Optimize the implementation of lanewise FIRST_NONZERO

Xiaohong Gong xgong at openjdk.org
Mon Aug 22 01:37:20 UTC 2022


On Wed, 17 Aug 2022 15:16:24 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>>> Looks good.
>> 
>> Thanks for looking at this patch @PaulSandoz ! 
>> 
>>> Much better to flip the operation and the receiver + first arg to the blend.
>> 
>> I'm not quite understand what the flip operation here mean. The current code is simple enough to me. Could you please show more details? Thanks a lot!
>
>> > Much better to flip the operation and the receiver + first arg to the blend.
>> 
>> I'm not quite understand what the flip operation here mean. The current code is simple enough to me. Could you please show more details? Thanks a lot!
> 
> I mean to say your approach is much better: changing `ne` to `eq` and changing the arguments to the blend.

Hi @PaulSandoz , may I get an approve from your side? Thanks so much!

-------------

PR: https://git.openjdk.org/jdk/pull/9683


More information about the core-libs-dev mailing list