RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v4]
Aleksey Shipilev
shade at openjdk.org
Mon Aug 22 09:49:35 UTC 2022
On Fri, 19 Aug 2022 18:14:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> We have a few reports that existing Weak* VarHandle tests are still flaky, for example on large AArch64 machines or small RISC-V machines.
>>
>> The flakiness is intrinsic to the nature of Weak* operations under tests, that can spuriously fail. The last attempt to fix these was [JDK-8155739](https://bugs.openjdk.org/browse/JDK-8155739). We need to strengthen these a bit more.
>>
>> The actual values depend on the successful testing on known-failing platforms. I ballparked bumping the attempts 5x and introducing the delay would help without exploding test time in worst cases.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>
> - Rework timeouts
> - Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
> - Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
> - Update copyrights
> - Also do Unsafe tests
> - Fix
Yes, so I have reworked this to please more machines. I have clean run on RPi 4 (AArch64), and semi-clean run on HiFive Unmatched board (there are still some timeouts, but no weak failures). I believe the `VarHandleTestMethodHandleAccess` are slow themselves, and pairing them with a very slow board would run into problems. I'll look into speeding up `VarHandles` tests even more in separate PR.
If anyone is interested how this PR behaves on their platforms, feel free to test it! Thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/9889
More information about the core-libs-dev
mailing list