RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory [v3]

[Jonathan Dowland]

On Thu, 25 Aug 2022 14:00:36 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address nit
>>   
>>   Thanks Thomas Stuefe
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupMetrics.java line 124:
> 
>> 122:     @Override
>> 123:     public long getMemoryLimit() {
>> 124:         long subs_mem = subsystem.getMemoryLimit();
> 
> Style nit: `subsMem` camelcase ;-)

Addressed in 01d07ab4b2e.

> src/java.base/linux/classes/jdk/internal/platform/CgroupMetrics.java line 126:
> 
>> 124:         long subs_mem = subsystem.getMemoryLimit();
>> 125:         // Catch the cgroup memory limit exceeding host physical memory.
>> 126:         // treat this as unlimited.
> 
> Nit: capital `T`.

Addressed in 85fa402acbb.

> src/java.base/linux/classes/jdk/internal/platform/CgroupMetrics.java line 128:
> 
>> 126:         // treat this as unlimited.
>> 127:         if (subs_mem >= getTotalMemorySize0()) {
>> 128:             return -1;
> 
> Please use `CgroupSubsystem.LONG_RETVAL_UNLIMITED` instead of this magic number.

Addressed in 01d07ab4b2e.

-------------

PR: https://git.openjdk.org/jdk/pull/10017