RFR: 8065554: MatchResult should provide values of named-capturing groups [v2]

Stuart Marks smarks at openjdk.org
Fri Aug 26 00:55:58 UTC 2022


On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti <duke at openjdk.org> wrote:

>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8065554: MatchResult should provide values of named-capturing groups

src/java.base/share/classes/java/util/regex/MatchResult.java line 106:

> 104:      * by {@link #namedGroups()}. It is thus sufficient to override
> 105:      * {@link #namedGroups()} for this method to work. However, overriding this
> 106:      * method directly might be preferable for performance or for other reasons.

This `@implNote` text, is repeated in three different methods. Consider moving this to the class specification. It might make it a bit easier for implementors to see a central overview instead of having this information in each method.

-------------

PR: https://git.openjdk.org/jdk/pull/10000


More information about the core-libs-dev mailing list