RFR: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks [v3]

[Alan Bateman]

On Fri, 26 Aug 2022 14:23:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Look at implementation and figure out what happens if you do:
>> 
>> 
>>  computeHash("SHA-1") = someHash;
>>  computeHash("SHA-256") = ...?
>> 
>> 
>> The caching method should actually check the algorithms match.
>> 
>> Not a bug at this point, since only use SHA-256 today, but this is a landmine ready to fire. 
>> 
>> Additional testing:
>>  - [x] Linux x86_64 release, `java/lang/module` tests
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Can you make sure that you run all jar, jmod and jlink tests? Module hashes are generated at packaging time, then checked when generating the configuration in early startup.

-------------

PR: https://git.openjdk.org/jdk/pull/10044