RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v7]
Aleksey Shipilev
shade at openjdk.org
Tue Aug 30 14:18:11 UTC 2022
> We have a few reports that existing Weak* VarHandle tests are still flaky, for example on large AArch64 machines or small RISC-V machines.
>
> The flakiness is intrinsic to the nature of Weak* operations under tests, that can spuriously fail. The last attempt to fix these was [JDK-8155739](https://bugs.openjdk.org/browse/JDK-8155739). We need to strengthen these a bit more.
>
> The actual values depend on the successful testing on known-failing platforms. I ballparked bumping the attempts 5x and introducing the delay would help without exploding test time in worst cases.
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
- Rewind back to 100 attempts, 1ms delay
- Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
- Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
- Pull Handles.get out of the weak retry loop
- Drop weakDelay to 1
- Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
- Rework timeouts
- Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
- Merge branch 'master' into JDK-8292407-varhandle-weak-resilient
- Update copyrights
- ... and 2 more: https://git.openjdk.org/jdk/compare/b3450e93...fd6aa17b
-------------
Changes: https://git.openjdk.org/jdk/pull/9889/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9889&range=06
Stats: 951 lines in 45 files changed: 800 ins; 0 del; 151 mod
Patch: https://git.openjdk.org/jdk/pull/9889.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9889/head:pull/9889
PR: https://git.openjdk.org/jdk/pull/9889
More information about the core-libs-dev
mailing list