RFR: JDK-8297215: Update libs tests to use @enablePreview [v3]

[Serguei Spitsyn]

On Thu, 1 Dec 2022 05:44:44 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Similar to an update recently done for langtools tests, update the libraries regression tests to take advantage of the @enablePreview jtreg feature.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Respond to review feedback.
>  - Merge branch 'master' into JDK-8297215
>  - Respond to review feedback.
>  - JDK-8297215: Update libs tests to use @enablePreview

Looks good.
Posted several nits though.
Thanks,
Serguei

test/jdk/java/lang/Thread/virtual/GetStackTraceWhenRunnable.java line 29:

> 27:  * @requires vm.continuations
> 28:  * @enablePreview
> 29:  * @compile GetStackTraceWhenRunnable.java

Nit: Is the line 29 for compiling necessary?

test/jdk/java/lang/instrument/ParallelTransformerLoaderTest.java line 37:

> 35:  * @library /test/lib
> 36:  * @run build TestClass1 TestClass2 TestClass3
> 37:   * @compile --enable-preview -source ${jdk.version} ParallelTransformerLoaderTest.java

Nit: This change is strange. It is either not needed or missing something.

test/jdk/java/lang/runtime/SwitchBootstrapsTest.java line 41:

> 39:  * @test
> 40:  * @enablePreview
> 41:  * @compile SwitchBootstrapsTest.java

Nit: Is the line 41 for compiling necessary?

test/jdk/java/net/vthread/HttpALot.java line 32:

> 30:  * @library /test/lib
> 31:  * @enablePreview
> 32:  * @compile HttpALot.java

Nit: Is the line 32 for compiling necessary?

test/jdk/java/net/vthread/InterruptHttp.java line 29:

> 27:  * @library /test/lib
> 28:  * @enablePreview
> 29:  * @compile InterruptHttp.java

Nit: Is the line 29 for compiling necessary?

test/jdk/jdk/jfr/event/runtime/TestThreadSleepEvent.java line 44:

> 42:  * @library /test/lib
> 43:  * @enablePreview
> 44:  * @compile TestThreadSleepEvent.java

Nit: Is the line 44 for compiling necessary?

test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java line 47:

> 45:  * @modules jdk.jfr/jdk.jfr.internal
> 46:  * @enablePreview
> 47:  * @compile TestManyVirtualThreads.java

Nit: Not sure the line 47 for compiling is necessary?

test/jdk/jdk/jfr/threading/TestNestedVirtualThreads.java line 45:

> 43:  * @modules jdk.jfr/jdk.jfr.internal
> 44:  * @enablePreview
> 45:  * @compile TestNestedVirtualThreads.java

Nit: Not sure the line 45 for compiling is necessary?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11222