RFR: 8297875: jar should not compress the manifest directory entry [v3]

Alan Bateman alanb at openjdk.org
Thu Dec 1 09:21:33 UTC 2022


On Thu, 1 Dec 2022 01:29:40 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This causes jar to not compress the `META-INF/` directory entry, for consistency with the handling of other directory entries and compliance with `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve test

src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 878:

> 876:                 ZipEntry e = new ZipEntry(MANIFEST_DIR);
> 877:                 setZipEntryTime(e);
> 878:                 e.setMethod(ZipEntry.STORED);

This should be okay, consistent with addFile where it will use STORED for directories.

-------------

PR: https://git.openjdk.org/jdk/pull/11441


More information about the core-libs-dev mailing list