RFR: 8291359: Specification of method j.l.foreign.VaList::skip still deserves clarification [v2]
Jorn Vernee
jvernee at openjdk.org
Fri Dec 2 17:03:46 UTC 2022
On Fri, 2 Dec 2022 16:45:56 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> This sentence still needs to be clarified IMHO. E.g. it is not clear when reading what "using a memory layout other than the layout of the accessed value" - since we are passing a layout to the access operation... it feels like we're trying to compress too much. We should say something like:
>>
>>
>> The values in a variable argument list are stored in one or more regions of memory in a platform specific fashion.
>> Any attempt to access (or skip) any such value with a mismatched memory layout (example) will result in undefined behavior.
>
> I think we don't need to say anything about how the values are stored. I wanted to avoid using the term "undefined behavior" at first as well, since it sounds like something that is defined elsewhere (which it isn't), but maybe that's okay. Though, I agree that what I have now doesn't quite feel right.
I've tried to re-write this to be more clear (including an example)
-------------
PR: https://git.openjdk.org/jdk/pull/11440
More information about the core-libs-dev
mailing list