RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Dec 6 12:48:18 UTC 2022


On Tue, 6 Dec 2022 12:05:26 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test
>
> test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamFinalizer.java line 175:
> 
>> 173:         public InputStream getInputStream() throws IOException {
>> 174:             if (finalized) {
>> 175:                 System.out.println(failureReason = "getInputStream called after finalize");
> 
> For ease of debugging, perhaps use `System.err.println` instead of `System.out`? That way the `Thread.dumpStack()` which is done on the next line will appear in the same jtreg section as this message.
> 
> Same comment in few other places where we have this construct.

I agree with Jaikiran that since we're not using testng here using `System.err` consistently is probably better.

-------------

PR: https://git.openjdk.org/jdk/pull/11474


More information about the core-libs-dev mailing list