RFR: 8295803: Console should be usable in jshell and other environments [v11]

Alan Bateman alanb at openjdk.org
Wed Dec 7 11:58:10 UTC 2022


On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is to allow Console to be used even when it is not attached to the platform provided terminal, such as the case when the standard input is redirected. `System.console()` now returns a Console implementation based on `jdk.internal.le` terminal by default, or jshell implementation if available. A corresponding CSR has been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Making the wrapper classes static

src/java.base/share/classes/java/io/Console.java line 625:

> 623:             };
> 624:             return AccessController.doPrivileged(pa);
> 625:         } catch (Throwable ignore) {

I don't think we should be catching and ignoring throwable here. The only case that would be okay to ignore here is SCE due to SecurityException as the jline provider doesn't work with a SM set.

-------------

PR: https://git.openjdk.org/jdk/pull/11421


More information about the core-libs-dev mailing list