RFR: 8295803: Console should be usable in jshell and other environments [v12]
Naoto Sato
naoto at openjdk.org
Wed Dec 7 19:19:28 UTC 2022
On Wed, 7 Dec 2022 18:57:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java line 167:
>
>> 165: @Override
>> 166: public void close() throws IOException {
>> 167: r.close();
>
> Console specifies that the invoking close on the Reader and Writer does not close the underlying stream. So I think this close (and WrappingWriter::close) need to be a no-op too.
Right. Made them as no-op.
-------------
PR: https://git.openjdk.org/jdk/pull/11421
More information about the core-libs-dev
mailing list