Integrated: 8298033: Character.codePoint{At|Before}(char[], int, int) doesn't do JavaDoc-specified check

[Sergey Tsypanov]

On Fri, 2 Dec 2022 12:44:18 GMT, Sergey Tsypanov <stsypanov at openjdk.org> wrote:

> I found out that this code
> 
> public class Main {
>     public static void main(String[] args) {
>         String s = "Hello world!";
>         char[] chars = s.toCharArray();
>         int point = Character.codePointAt(chars, -1, 1);
>     }
> }
> 
> throws `ArrayIndexOutOfBoundsException` instead of JavaDoc-specified `IndexOutOfBoundsException`: 
> 
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 12
> 	at java.base/java.lang.Character.codePointAtImpl(Character.java:9254)
> 	at java.base/java.lang.Character.codePointAt(Character.java:9249)
> 	at org.example.Main.main(Main.java:7)
> 
> and the method doesn't check whether `index` parameter is negative:
> 
> public static int codePointAt(char[] a, int index, int limit) {
>     if (index >= limit || limit < 0 || limit > a.length) {
>         throw new IndexOutOfBoundsException();
>     }
>     return codePointAtImpl(a, index, limit);
> }
> 
> I suggest to check the `index` parameter explicitly instead of relying on AIOOBE thrown from accessing the array with negative index.

This pull request has now been integrated.

Changeset: b9346e14
Author:    Sergey Tsypanov <stsypanov at openjdk.org>
Committer: Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b9346e149e6cfcaf18bfafbd262f6fed209dc644
Stats:     7 lines in 2 files changed: 0 ins; 1 del; 6 mod

8298033: Character.codePoint{At|Before}(char[], int, int) doesn't do JavaDoc-specified check

Reviewed-by: rriggs

-------------

PR: https://git.openjdk.org/jdk/pull/11480