RFR: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86

[Jaikiran Pai]

On Tue, 13 Dec 2022 00:06:00 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The `java/lang/String/StringRepeat.java` test was updated twice after integration:
> 
> https://bugs.openjdk.org/browse/JDK-8221400 - the xmx4g was replaced by the xmx2g
> https://bugs.openjdk.org/browse/JDK-8265421 - the "os.maxMemory >= 2G" was added
> 
> Unfortunately, this test still may fail on Windows x86 due to: `Could not reserve enough space for xxx object heap.`
> 
> This is a request to exclude it on win x86 since that JDK cannot allocate 2g.

Thank you for that detail. The change looks fine to me then. I had to look if multiple `@requires` are supported in a test definition by jtreg and apparently it does support it:

https://openjdk.org/jtreg/tag-spec.html
> The @requires tag may be used multiple times in a given test. If it is used more than once, the expressions in the individual instances will be enclosed in parentheses and combined with '&'.

Please wait for another review before integrating, since I don't have previous experience with this test.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11639