RFR: 8298416: Console should be declared `sealed` [v2]

Naoto Sato naoto at openjdk.org
Wed Dec 14 17:35:49 UTC 2022


On Wed, 14 Dec 2022 08:46:58 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Making fields final, other clean-ups
>>  - Merge branch 'master' into JDK-8298416-SealedConsole
>>  - tidying up
>>  - sealed Console, impl/if separation
>
> src/java.base/share/classes/java/io/Console.java line 359:
> 
>> 357:      * @return true if the previous console echo status is on
>> 358:      */
>> 359:     static native boolean echo(boolean on) throws IOException;
> 
> I think echo should move to ConsoleImpl too. It might be okay to leave the native method in Console_md.c, then it would be just renaming the JNI function.

Moved the method into ConsoleImpl

-------------

PR: https://git.openjdk.org/jdk/pull/11615


More information about the core-libs-dev mailing list