RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

Jaikiran Pai jpai at openjdk.org
Thu Dec 15 07:00:08 UTC 2022


On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> This is an approach to adding a flag to jlink that will allow --compress to take the same types of arguments as jmod, thus bringing the two into alignment. This likely requires a CSR and a discussion on whether we should deprecate or simply remove the original numeric compression arguments.
>
> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Swapping deprecations in properties

src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line 73:

> 71: 
> 72: compress.usage=\
> 73: \  --compress <0|1|2|zip-[0-9]>[:filter=<pattern-list>]\n\

This is a bit odd - when I run the `jlink`  command against latest mainline, I don't see the `[:filter=<pattern-list>]` being displayed in the help output nor do I see the message which states `An optional <pattern-list> ....`. This is what the `jlink --help` looks like against current mainline:
(first check the version)

jlink --version
21-internal

(check help output)

jlink --help
Usage: jlink <options> --module-path <modulepath> --add-modules <module>[,<module>...]
Possible options include:
      --add-modules <mod>[,<mod>...]    Root modules to resolve in addition to the
                                        initial modules. <mod> can also be ALL-MODULE-PATH.
      --bind-services                   Link in service provider modules and
                                        their dependences
  -c, --compress=<0|1|2>                Enable compression of resources:
                                          Level 0: No compression
                                          Level 1: Constant string sharing
                                          Level 2: ZIP


So it appears that this is not where the `-c --compress` option's help text is being picked up from?

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list