RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

Jaikiran Pai jpai at openjdk.org
Thu Dec 15 07:35:08 UTC 2022


On Thu, 15 Dec 2022 07:01:05 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Swapping deprecations in properties
>
> test/jdk/tools/jlink/plugins/CompressorPluginTest.java line 153:
> 
>> 151:         Properties optionsZip0 = new Properties();
>> 152:         DefaultCompressPlugin compressPluginZip0 = new DefaultCompressPlugin();
>> 153:         options0.setProperty(compressPluginZip0.getName(), "zip-0");
> 
> I suspect this supposed to be `optionsZip0.setProperty(....)` instead of `options0.setProperty(....)`?

I think, there's also a typo in the next line:

checkCompress(classes, compressPlugin,

should have been:

checkCompress(classes, compressPluginZip0,

I haven't yet looked at the existing test code in `checkCompress` method, but it might need a closer look as to why this test passed. I would have expected it to fail due to the typos.

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list