RFR: 8279598: Provide adapter from RandomGenerator to Random [v3]

Roger Riggs rriggs at openjdk.java.net
Thu Feb 3 21:36:08 UTC 2022


On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi <duke at openjdk.java.net> wrote:

>> Hi, could i get a review on this implementation proposed by Stuart Marks, i decided to use the https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html interface to create the default method `asRandom()` that wraps around the newer algorithms to be used on classes that do not accept the new interface.
>> 
>> Some things to note as proposed by the bug report, the protected method next(int bits) is not overrided and setSeed() method if left blank up to discussion on what to do with it.
>> 
>> Small test done on https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
>
> Yasser Bazzi has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - fix missing periods
>  - Use final on initialized variable

Either is fine.  A new PR might just look a bit cleaner; your choice.
All the code changes would be in Random plus the test, and an informational note in RandomGenerator or @ see to the method in Random would be a good cross reference.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7001


More information about the core-libs-dev mailing list