RFR: 8281168: Micro-optimize VarForm.getMemberName for interpreter [v2]

Aleksey Shipilev shade at openjdk.java.net
Tue Feb 8 17:11:48 UTC 2022


On Tue, 8 Feb 2022 14:16:15 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Comment
>>  - Merge branch 'master' into JDK-8281168-int-varform
>>  - Fix
>
> src/java.base/share/classes/java/lang/invoke/VarForm.java line 112:
> 
>> 110:     @ForceInline
>> 111:     final MemberName getMemberName(int mode) {
>> 112:         MemberName mn = memberName_table[mode];
> 
> It makes sense to leave a comment here why inlining `getMemberNameOrNull()` makes sense.  Otherwise, looks good.

Added comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7333


More information about the core-libs-dev mailing list