RFR: 8279995: jpackage --add-launcher option should allow overriding description

Alexey Semenyuk asemenyuk at openjdk.java.net
Wed Feb 9 19:34:12 UTC 2022


On Wed, 9 Feb 2022 18:53:35 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> test/jdk/tools/jpackage/share/AddLauncherTest.java line 93:
>> 
>>> 91:         new AdditionalLauncher("Baz2")
>>> 92:                 .setDefaultArguments()
>>> 93:                 .addRawProperties(Map.entry("description", "Baz2 Description"))
>> 
>> How expected description is verified in the test?
>
> I do not think that we have ability to check description on executable files. I added it for manual verification.

Powershell can be used to extract the description from an executable. E.g.:

$ powershell -NoLogo -NoProfile -Command "(Get-Item build\\windows-x64\\images\\jdk\\bin\\java.exe).VersionInfo | select FileDescription"

FileDescription
---------------
Java(TM) Platform SE binary


You can create jdk.jpackage.test.AdditionalLauncher.verifyDescription() function that will call this script and call this function from jdk.jpackage.test.AdditionalLauncher.verify().

-------------

PR: https://git.openjdk.java.net/jdk/pull/7399


More information about the core-libs-dev mailing list