RFR: JDK-8281462: Annotation toString output for enum not reusable for source input [v2]

Joe Darcy darcy at openjdk.java.net
Fri Feb 11 20:42:10 UTC 2022


On Fri, 11 Feb 2022 15:24:45 GMT, Sam Brannen <duke at openjdk.java.net> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java line 148:
> 
>> 146:         StringBuilder result = new StringBuilder(128);
>> 147:         result.append('@');
>> 148:         // Guard against shouldn't-happen NPE for a missing canonical name
> 
> NIT: A NPE would not be thrown. Rather, `"null"` would be appended to the buffer. Right?

Update comment in latest push.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7418


More information about the core-libs-dev mailing list