RFR: 8281728: Redundant null check in LineNumberInputStream.read

Claes Redestad redestad at openjdk.java.net
Mon Feb 14 10:44:11 UTC 2022


On Wed, 9 Feb 2022 18:51:22 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> At start of method `b` is already checked for null.
> 
> https://github.com/openjdk/jdk/blob/178b962e01cc6c150442bf41dc6bd199caff0042/src/java.base/share/classes/java/io/LineNumberInputStream.java#L129-L131

Looks good. The surrounding code looks due for a larger clean-up, but this improvement looks reasonable in isolation.

-------------

Marked as reviewed by redestad (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7409


More information about the core-libs-dev mailing list