RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

[Volker Simonis]

On Thu, 17 Feb 2022 10:01:11 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed hardcoded constant to JMH parmater and removed non-ASCII chars from comments
>
> test/micro/org/openjdk/bench/java/util/zip/InflaterInputStreams.java line 78:
> 
>> 76:     private byte[] words;
>> 77:     private static final int MAX_SIZE = 5000; // Should be bigger than the biggest size @Param
>> 78:     private static byte[] inflated = new byte[MAX_SIZE];
> 
> If it isn't important for the benchmark, I'd remove the hard-coded `MAX_SIZE` and make `inflated` non-static and allocate it in `beforeRun` using `size` (or some multiple thereof). Future enhancements could very well be interested in assessing the performance of larger sized entries, and we shouldn't put up trip-wires if they want to increase `size`.

Sure , you're absolutely right. Updated as suggested.

I've also removed some non-ASCII characters from the comment to avoid problems with javac.

Finally, a year isn't required in the Amazon copyright header. We specially removed all years a while back.

PS: and thanks a lot for your review :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7492