RFR: JDK-8266670: Better modeling of access flags in core reflection [v5]

Joe Darcy darcy at openjdk.java.net
Thu Feb 17 18:45:11 UTC 2022


On Wed, 16 Feb 2022 13:18:47 GMT, ExE Boss <duke at openjdk.java.net> wrote:

>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Reorder constants by mask value per review feedback.
>>  - Merge branch 'master' into JDK-8266670
>>  - Respond to more review feedback.
>>  - Respond to review feedback explicitly stating returned sets are immutable.
>>  - Fix typo from review feedback.
>>  - Merge branch 'master' into JDK-8266670
>>  - JDK-8266670: Better modeling of modifiers in core reflection
>
> test/jdk/java/lang/reflect/AccessFlag/BasicAccessFlagTest.java line 65:
> 
>> 63:             if (left.mask() > right.mask()) {
>> 64:                 throw new RuntimeException(left
>> 65:                                            + "has a greater mas than "
> 
> Typo:
> Suggestion:
> 
>                                            + "has a greater mask than "

Will correct in next push; thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7445


More information about the core-libs-dev mailing list