RFR: JDK-8266670: Better modeling of access flags in core reflection [v12]

[Joe Darcy]

On Wed, 23 Feb 2022 17:05:58 GMT, ExE Boss <duke at openjdk.java.net> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Initial support for accessFlags methods
>
> src/java.base/share/classes/java/lang/Class.java line 1331:
> 
>> 1329:         // This likely needs some refinement. Exploration of hidden
>> 1330:         // classes, array classes.  Location.CLASS allows SUPER and
>> 1331:         // AccessFlag.MODULE with INNER_CLASS forbids. INNER_CLASS
> 
> Typo:
> Suggestion:
> 
>         // AccessFlag.MODULE which INNER_CLASS forbids. INNER_CLASS

Thanks; will fix in next push.

> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 367:
> 
>> 365:                                        INTERFACE, ABSTRACT,
>> 366:                                        SYNTHETIC, ANNOTATION,
>> 367:                                        ENUM, AccessFlag.MODULE)),
> 
> I don’t think that this needs to be qualified:
> Suggestion:
> 
>                                        ENUM, MODULE)),

It does because of the AccessFlags.MODULE constant.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7445