RFR: 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale [v3]

[Jaikiran Pai]

On Thu, 24 Feb 2022 17:15:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - use Roger's suggestion of using Stream and Collection based APIs to avoid code duplication in the data provider method of the test
>>  - no need for system.out.println since testng add the chosen params to the output logs
>>  - review comments:
>>      - upper case static final fields in test
>>      - use DateTimeFormatter.ofPattern(DATE_FORMAT_PATTERN, Locale.ROOT)
>>  - remove @modules declaration on the jtreg test
>
> test/jdk/java/util/Properties/PropertiesStoreTest.java line 112:
> 
>> 110:         locales.add(Locale.getDefault()); // always test the default locale
>> 111:         locales.add(Locale.US); // guaranteed to be present
>> 112:         locales.add(Locale.ROOT); // guaranteed to be present
> 
> Can we assume the returned `Set<Locale>` is mutable? `Collectors.toSet()` javadoc reads no guarantee for mutability.

That's a very good point. I've updated the PR to now explicitly use a mutable `Set` instead of using `Collectors.toSet()`

-------------

PR: https://git.openjdk.java.net/jdk/pull/7558