RFR: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX [v4]

[Ichiroh Takiguchi]

On Fri, 25 Feb 2022 15:03:19 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add null check
>
> My preference is to pass the unmodified LIBPATH in the environment in each of the three cases.
> The expected checks already expect the unmodified LIBPATH so the only change is in the setup of the environment to be passed to the child.
> 
> Already covered at line 1366:
> 
> Insert at line 1873 in the if/then/else:
> 
>             } else if (AIX.is()) {
>                 envp = new String[] {"=ExitValue=3", "=C:=\", "LIBPATH="+libpath};
>             } else {
> 
> (Or assign it to a local as is done for windows, your preference).
> 
> And at line 1921'ish:
> ``` 
>            } else if (AIX.is()) {
>                 envp = new String[] {"LC_ALL=C\u0000\u0000", // Yuck!
>                         "FO\u0000=B\u0000R", "LIBPATH="+libpath};
> 
> 
> I looked using `sh -c env` but I think it would be more work to change the way the output is compared.
> The output of `env` is different and has some other values that get inserted.

Many thanks, @RogerRiggs .
I tried your suggested code, it worked fine on my AIX system.
Could you review this change again ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7574