[jdk18] Integrated: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

Aleksey Shipilev shade at openjdk.java.net
Thu Jan 13 08:54:41 UTC 2022


On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Seems like a missing include. C++ docs say `offsetof` is from `<cstddef>`, adding that include explicitly fixes the build. Seems to only happen with older GCCs, but it seems to be a happy accident it works on newer ones, probably through the transitive include somewhere.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `tools/jpackage` tests
>  - [x]  Linux x86_64 release `tools/jpackage` tests

This pull request has now been integrated.

Changeset: 14a90e53
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk18/commit/14a90e536b86a8fb8d5f0272ec03359e44638da5
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

Reviewed-by: almatvee, asemenyuk

-------------

PR: https://git.openjdk.java.net/jdk18/pull/74


More information about the core-libs-dev mailing list