RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

Daniel Fuchs dfuchs at openjdk.java.net
Fri Jan 14 11:09:47 UTC 2022


On Fri, 14 Jan 2022 10:03:37 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 180:
>> 
>>> 178:     static String normalizeCBT(String s) {
>>> 179:         if (s == null || ! (s.equals("always") ||
>>> 180:                 s.equals("never") || s.startsWith("domain:"))) {
>> 
>> I guess there's a `!` missing in front of  `s.startsWith("domain:")` here?
>
> This is what was intended (equivalent)
> 
> `if (s ==null || (s!="always" && s!="never" && !s.startsWith("domain")))`

Argh - you're right I missed the fact that the 3 expressions where included in parenthesis. I read it as 

! (s.equals("always")) || ...

-------------

PR: https://git.openjdk.java.net/jdk/pull/7065


More information about the core-libs-dev mailing list